refactor: separate test support from production paths - #113
Merged
Conversation
danielkov
enabled auto-merge (squash)
September 5, 2026 21:00
danielkov
force-pushed
the
refactor/test-boundaries
branch
from
September 5, 2026 22:21
ea74d71 to
1842026
Compare
![kit-code-agent[bot]](https://avatars.githubusercontent.com/in/4797102?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document test boundaries in AGENTS.md and remove test-only production switches, instrumentation, and alternate implementations. Keep fixtures in test modules and exercise real replay, cancellation, registration, cache, and transport paths.
Impact
Detached tool completion now seals the live TUI agent stream through
ToolPatched; that behavior previously existed only in a test-only event.Technical details
Fakes stay at external boundaries
Local Git fixtures use the existing subprocess interface. JWKS fixtures supply fetched documents while exercising production cache and signature-validation logic. Production Git remains HTTPS-only and OpenAI signing-key retrieval stays pinned.
Outcomes replace implementation spies
Replace synthetic ACP turn control and response-order callbacks with real session handles, committed injection receipts, and in-memory transport exchanges. Rendering assertions retain visible-metadata and cache-content coverage without claiming to prove bounded work.